Return URL params in HandlerOptions #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alecthomas What's your position on this change? I've come across a case where an Options Handler needs access to information contained in the url params.
eg:
//happy:api GET /v1/metrics/:orgId authenticated permissionedIn this case the
permissionedoption handler needs access to:orgIdin the URL to determine if the authenticated user has access to that org.This PR changes the
[]stringof params to amap[string]stringand merges it's content with the options map. I feel it's a little hacky but to fix it properly required substantial more work. Next stage I think we should factor out the route, params & body parsing section out as it's kind of duplicated inServeHTTPandHandlerOptions..